Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing projections #8

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Introducing projections #8

merged 1 commit into from
Aug 21, 2023

Conversation

huntc
Copy link
Collaborator

@huntc huntc commented Aug 15, 2023

Here are the traits and types being proposed. These correspond reasonably well with their JVM counterparts but with the queries conflated into the providers as discussed offline:

image

Along the way, I've also dropped the naming of Record for entities and now use EventEnvelope, which is consistent with its use elsewhere.

TODO (in another PR):

  • implement the source provider for the commit log
  • implement the projection runner
  • implement the gRPC source provider

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good starting point that can be merged (soon)

},
"iot-service-projection",
registration::EVENTS_TOPIC,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be missing the slice range that this projection should handle, but slices can come later in a separate step and we start with all slices.

Corresponding jvm example https://doc.akka.io/docs/akka-projection/current/r2dbc.html#running-with-sharded-daemon-process
or with grpc https://doc.akka.io/docs/akka-projection/current/grpc.html#consumer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I've not put a ton of consideration into the slice mechanism just yet. I'll tackle that with the next PR as you suggest.

@huntc huntc marked this pull request as ready for review August 21, 2023 07:17
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huntc huntc merged commit fe3cd83 into main Aug 21, 2023
1 check passed
@huntc huntc deleted the projections branch August 21, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants