Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortify SCA 24.2.0 (was 23.1.1) #40

Merged
merged 3 commits into from
May 31, 2024
Merged

Fortify SCA 24.2.0 (was 23.1.1) #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
931fe0f
SCA 24.2.0 (was 23.1.1)
SethTisue May 31, 2024
ac0d03c
wip
SethTisue May 31, 2024
2f59e6a
wip
SethTisue May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/fortify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
cache-name: fortify
with:
path: ./Fortify
key: fortify-23.1.1
key: fortify-24.2.0

# https://github.com/gruntwork-io/fetch
- uses: Homebrew/actions/setup-homebrew@master
Expand All @@ -50,21 +50,21 @@ jobs:
- name: Install Fortify
run: |
if [[ ! -d Fortify ]] ; then
GITHUB_OAUTH_TOKEN=${{secrets.FORTIFY_INSTALLER_TOKEN}} fetch --repo="https://github.com/lightbend/scala-fortify" --tag="23.1.1_linux_x64" --release-asset="Fortify_SCA_23.1.1_linux_x64.run" .
chmod +x Fortify_SCA_23.1.1_linux_x64.run
GITHUB_OAUTH_TOKEN=${{secrets.FORTIFY_INSTALLER_TOKEN}} fetch --repo="https://github.com/lightbend/scala-fortify" --tag="24.2.0_linux_x64" --release-asset="Fortify_SCA_24.2.0_linux_x64.run" .
chmod +x Fortify_SCA_24.2.0_linux_x64.run
mkdir Fortify
echo installdir=`pwd`/Fortify/Fortify_SCA_23.1.1 > Fortify_SCA_23.1.1_linux_x64.run.options
echo fortify_license_path=`pwd`/fortify.license >> Fortify_SCA_23.1.1_linux_x64.run.options
./Fortify_SCA_23.1.1_linux_x64.run --mode unattended
echo installdir=`pwd`/Fortify/Fortify_SCA_24.2.0 > Fortify_SCA_24.2.0_linux_x64.run.options
echo fortify_license_path=`pwd`/fortify.license >> Fortify_SCA_24.2.0_linux_x64.run.options
./Fortify_SCA_24.2.0_linux_x64.run --mode unattended
# download the Scala security rules; VersionTests makes sure they're the ones we expect
./Fortify/Fortify_SCA_23.1.1/bin/fortifyupdate
./Fortify/Fortify_SCA_24.2.0/bin/fortifyupdate
fi

- name: Test
run: |
sbt ++${{matrix.scala}} compile
rm -f target/vulnerabilities-actual.txt
./Fortify/Fortify_SCA_23.1.1/bin/sourceanalyzer \
./Fortify/Fortify_SCA_24.2.0/bin/sourceanalyzer \
-b akka-http-webgoat \
-logfile target/scan.log \
-scan \
Expand Down
4 changes: 2 additions & 2 deletions fortify.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// enable the plugin
addCompilerPlugin(
"com.lightbend" %% "scala-fortify" % "1.1.0"
"com.lightbend" %% "scala-fortify" % "1.1.1-RC1"
cross CrossVersion.patch)

// configure the plugin
scalacOptions ++= Seq(
"-P:fortify:scaversion=23.1",
"-P:fortify:scaversion=24.2",
"-P:fortify:build=akka-http-webgoat"
)
3 changes: 0 additions & 3 deletions vulnerabilities-2.13.x.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,3 @@ Routes.scala(51) : ->ProcessBuilder.!!(this)
Routes.scala(139) : <=> (this)
Routes.scala(139) : <->akka.http.webgoat.Routes$$anonfun$commandInjectionFromCookie$2.innerinit^(0->this)
Routes.scala(138) : ->akka.http.webgoat.Routes$$anonfun$commandInjectionFromCookie$1.apply(0)

[C28720E53777D9E9CB1598CACD02F9E7 : low : J2EE Bad Practices : Leftover Debug Code : structural ]
BootWebGoat.scala(11)
20 changes: 0 additions & 20 deletions vulnerabilities-3.x.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,23 +164,3 @@ Routes.scala(51) : ->ProcessBuilder.!!(this)
Routes.scala(139) : <=> (this)
Routes.scala(139) : <->akka.http.webgoat.Routes$commandInjectionFromCookie$lzyINIT1$$anonfun$1$$anonfun$1.innerinit^(0->this)
Routes.scala(138) : ->akka.http.webgoat.Routes$commandInjectionFromCookie$lzyINIT1$$anonfun$1.apply(0)

[3C19C215BE7A8DF59CD47FC24DAF64B0 : low : Code Correctness : Constructor Invokes Overridable Function : structural ]
BootWebGoat.scala(16)
Function: akka.http.webgoat.BootWebGoat.BootWebGoat [BootWebGoat.scala(11)]
Function: akka.http.webgoat.BootWebGoat.system [BootWebGoat.scala(12)]

[3C19C215BE7A8DF59CD47FC24DAF64B1 : low : Code Correctness : Constructor Invokes Overridable Function : structural ]
BootWebGoat.scala(16)
Function: akka.http.webgoat.BootWebGoat.BootWebGoat [BootWebGoat.scala(11)]
Function: akka.http.webgoat.BootWebGoat.system [BootWebGoat.scala(12)]

[3C19C215BE7A8DF59CD47FC24DAF64B2 : low : Code Correctness : Constructor Invokes Overridable Function : structural ]
BootWebGoat.scala(21)
Function: akka.http.webgoat.BootWebGoat.BootWebGoat [BootWebGoat.scala(11)]
Function: akka.http.webgoat.BootWebGoat.system [BootWebGoat.scala(12)]

[3C19C215BE7A8DF59CD47FC24DAF64B3 : low : Code Correctness : Constructor Invokes Overridable Function : structural ]
BootWebGoat.scala(33)
Function: akka.http.webgoat.BootWebGoat.BootWebGoat [BootWebGoat.scala(11)]
Function: akka.http.webgoat.BootWebGoat.system [BootWebGoat.scala(12)]