-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative way of defining Graph Stages #122
Comments
It seems I got into still water.. |
So much things to do and so little time to do it in I'm afraid, and reviews do take a lot of time, so I can't give you any estimate on when we'll get to review it, sorry! My gut feeling is that it is quite intricate/complex machinery/API for something we don't hear much complaints about/see many problems with. I have only very quickly skimmed the PR though. In general, for future contributions it may help to start out with a discussion of the problem as an issue first before making a more advanced PR like this. |
Thank you very much for your answer. I'm writing a server on Akka Streams, which has several tens of thousands of lines of source code. All server components are exclusively components of the Graph Stage. Dozens of static components are materialized into a single complex graph. For creating/removing and interacting with temporary components, I used own Dynamic Flow. Combining all the components into a single complex graph, I got all the benefits of Akka Streams. At the same time, there was a problem of convenient back-pressure monitoring. Using manual pull/grab/push control within each Graph Stage, it's hard to avoid mistakes, but it's easy to complicate the code. And if consider that the use of Akka Streams does not exclude a problem like deadlock, revealing the potential cause of such a situation in the absence of a descriptive part of the back-pressure control becomes very difficult task. Therefore, there was an idea of creating a higher level GraphStageLogic, the use of which would allow:
All these tasks are solved by the LinkedLogics/TimerLinkedLogics components, which has been successfully applied in my system for more than a year. I will be glad for the further discussion. |
Hi. Could anyone review my PR #121?
The text was updated successfully, but these errors were encountered: