Add log filtering integration #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| In Akka.NET 1.5.21, we introduced [log filtering for log messages based on the LogSource or the content of a log message](https://getakka.net/articles/utilities/logging.html#filtering-log-messages). Depending on your coding style, you can use this feature in Akka.Hosting in several ways. | ||
|
|
||
| 1. Using the `WithLogFilter()` `AkkaConfigurationBuilder` extension method. |
README.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| 2. Using The `LoggerConfigBuilder.WithLogFilter()` method. |
| [Fact(DisplayName = "WithLogFilter should inject LogFilterSetup")] | ||
| public void WithLogFilterSetupTest() | ||
| { | ||
| var builder = new AkkaConfigurationBuilder(new ServiceCollection(), "fake") |
| @@ -96,6 +98,13 @@ public LoggerConfigBuilder ClearLoggers() | |||
| return this; | |||
| } | |||
|
|
|||
| public LoggerConfigBuilder WithLogFilter(Action<LogFilterBuilder> filterBuilder) | |||
There was a problem hiding this comment.
One thing I'm not so sure about - what happens if someone calls this and ConfigureLogging (or whatever it's called?) - can't we end up with one config overriding the other?
There was a problem hiding this comment.
Yes, the two implementation inside ConfigureLoggers(builder) and the extension method AkkaConfigurationBuilder.WithLogFilter() is exclusive to each other. The first being added would win because of how we retrieve Setup classes in ActorSystem.Settings
There was a problem hiding this comment.
LGTM - we decided to stick with just the LogConfigBuilder.
Aaronontheweb
approved these changes
Jun 4, 2024
README.md
Outdated
| builder.Services.AddAkka("MyActorSystem", configurationBuilder => | ||
| { | ||
| configurationBuilder | ||
| .WithLogFilter(filterBuilder => |
There was a problem hiding this comment.
LGTM - glad we consolidated this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.