Fix how ClusterShardingSettings were applied #480
Conversation
| @@ -850,7 +874,7 @@ public static class AkkaClusterHostingExtensions | |||
| IMessageExtractor messageExtractor, | |||
| ShardOptions shardOptions) | |||
| { | |||
| shardOptions.Apply(builder); | |||
| shardOptions.DistributedData.Apply(builder); | |||
There was a problem hiding this comment.
Just don't worry about DData settings. Please remove this entirely from the API. Let users configure DData separately if needed. Only stick to what's in the ClusterShardingSettings class for this.
There was a problem hiding this comment.
how would the user set the akka.cluster.sharding.distribute-data settings then?
There was a problem hiding this comment.
If a situation arises where they would ever need to do it, they can do it through HOCON.
…a.Hosting into fix-cluster-sharding-setup
There was a problem hiding this comment.
LGTM but add a regression spec to verify that two different ShardRegions in the same node can be configured with separate:
- Remember entities
- Passivization settings
- Roles
You don't need to end2end this spec - just testing the ClusterShardingSettings output produced by consuming the shardOptions.ToConfig() should be fine.
| var coordinatorConfig = system.Settings.Config.GetConfig( | ||
| shardingConfig.GetString("coordinator-singleton")); | ||
|
|
||
| var settings = ClusterShardingSettings.Create(shardingConfig, coordinatorConfig); |
|
Done |
Fixes #477
Previously, settings were applied directly to the HOCON configuration, setting up a cluster shard region using
ShardOptionswould not work because only the lastShardOptionswould be applied to the HOCON configuration.Changes
ShardOptionsto be applied separately perWithShardRegion()call.Note
Distributed data settings for all shard regions are still stored as a single HOCON setting (
akka.cluster.sharding.distributed-data), they are not applied on a per region basis.