-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DistributedPubSub: make query to count local subscribers for topic public #6856
DistributedPubSub: make query to count local subscribers for topic public #6856
Conversation
…blic close akkadotnet#3663 - between this and `Topic`s all local data should be queryable for distributed pub-sub
/// </summary> | ||
internal sealed class CountSubscribers | ||
public sealed class CountSubscribers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made this internal
class public
- left it inside the .Internal
namespace though (which I think this fine - it's public but we reserve the right to change it, per our API guidelines: https://getakka.net/community/contributing/api-changes-compatibility.html#akkanet-api-versioning-policy )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to decorate this class with [ApiMayChange]
attribute for documentation purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nitpick
/// </summary> | ||
internal sealed class CountSubscribers | ||
public sealed class CountSubscribers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to decorate this class with [ApiMayChange]
attribute for documentation purposes
Changes
close #3663 - between this and
Topic
s all local data should be queryable for distributed pub-subChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):