Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DistributedPubSub: make query to count local subscribers for topic public #6856

Merged
merged 4 commits into from
Jul 27, 2023
Merged

DistributedPubSub: make query to count local subscribers for topic public #6856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
389a5eb
DistributedPubSub: make query to count local subscribers for topic pu…
Aaronontheweb Jul 27, 2023
5527170
Merge branch 'dev' into close-3663-countTopics
Arkatufus Jul 27, 2023
6e8ab36
added `ApiMayChange` attribute
Aaronontheweb Jul 27, 2023
5672e07
Merge branch 'close-3663-countTopics' of https://github.com/Aarononth…
Aaronontheweb Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/Internal/TopicMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using System.Collections.Immutable;
using System.Linq;
using Akka.Actor;
using Akka.Annotations;
using Akka.Event;
using Akka.Routing;

Expand Down Expand Up @@ -42,9 +43,10 @@ private Count() { }
}

/// <summary>
/// TBD
/// Get all subscribers for a given topic.
/// </summary>
internal sealed class CountSubscribers
[ApiMayChange]
public sealed class CountSubscribers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made this internal class public - left it inside the .Internal namespace though (which I think this fine - it's public but we reserve the right to change it, per our API guidelines: https://getakka.net/community/contributing/api-changes-compatibility.html#akkanet-api-versioning-policy )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to decorate this class with [ApiMayChange] attribute for documentation purposes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

{
public string Topic { get; }

Expand Down
9 changes: 9 additions & 0 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,15 @@ namespace Akka.Cluster.Tools.PublishSubscribe
public override string ToString() { }
}
}
namespace Akka.Cluster.Tools.PublishSubscribe.Internal
{
[Akka.Annotations.ApiMayChangeAttribute()]
public sealed class CountSubscribers
{
public CountSubscribers(string topic) { }
public string Topic { get; }
}
}
namespace Akka.Cluster.Tools.PublishSubscribe.Serialization
{
public class DistributedPubSubMessageSerializer : Akka.Serialization.SerializerWithStringManifest
Expand Down
9 changes: 9 additions & 0 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,15 @@ namespace Akka.Cluster.Tools.PublishSubscribe
public override string ToString() { }
}
}
namespace Akka.Cluster.Tools.PublishSubscribe.Internal
{
[Akka.Annotations.ApiMayChangeAttribute()]
public sealed class CountSubscribers
{
public CountSubscribers(string topic) { }
public string Topic { get; }
}
}
namespace Akka.Cluster.Tools.PublishSubscribe.Serialization
{
public class DistributedPubSubMessageSerializer : Akka.Serialization.SerializerWithStringManifest
Expand Down
Loading