Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SaveSnapshot timestamp metadata #7334

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix SaveSnapshot timestamp metadata #7334

merged 1 commit into from
Sep 4, 2024

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Sep 4, 2024 •
edited
Loading

Currently, when SaveSnapshot() is invoked, the Metadata.Timestamp is ignored and always replaced with DateTime.UtcNow

Changes

SnapshotStore should only override the metadata timestamp if it is not set (DateTime.MinValue)

Arkatufus
Arkatufus commented Sep 4, 2024
View reviewed changes
Copy link
Contributor Author

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

src/core/Akka.Persistence/Snapshot/SnapshotStore.cs Show resolved Hide resolved
src/core/Akka.Persistence/Snapshot/SnapshotStore.cs Show resolved Hide resolved
@Aaronontheweb
Copy link
Member

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) September 4, 2024 17:10
This was referenced Sep 4, 2024
Merged
Merged
@Aaronontheweb Aaronontheweb merged commit cb11702 into akkadotnet:dev Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb