Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateTimeOffset.DateTime UTC bug #7349

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix DateTimeOffset.DateTime UTC bug #7349

merged 2 commits into from
Sep 30, 2024

Conversation

Arkatufus
Copy link
Contributor

Fixes https://github.com/akkadotnet/akka.net/blame/554086ccba07338194aca2a1eb8e0f9d801973b7/src/core/Akka.Persistence/Eventsourced.cs#L221

  1. It uses DateTimeOffset.Date which strips the time portion of the DateTime struct
  2. DateTimeOffset.DateTime returns a DateTime object with DateTimeKind.Unspecified and we need DateTimeKind.Utc

Changes

Add a new property in ITimeProvider interface that returns a DateTime.UtcNow

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Aaronontheweb
Aaronontheweb approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb added this to the 1.5.29 milestone Sep 30, 2024
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) September 30, 2024 18:26
@Aaronontheweb Aaronontheweb merged commit 33fd92d into akkadotnet:dev Sep 30, 2024
9 of 12 checks passed
@Arkatufus Arkatufus mentioned this pull request Oct 1, 2024
Merged
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Oct 3, 2024
@Arkatufus
Revert "Fix DateTimeOffset.DateTime UTC bug (akkadotnet#7349)"
f682c38 
This reverts commit 33fd92d.
Aaronontheweb pushed a commit that referenced this pull request Oct 3, 2024
@Arkatufus
Revert #7349 and #7352 (#7353)
e5aebed 
* Revert "Fix unit tests related to the Persistence DateTime bug (#7352)"

This reverts commit f5c4e63.

* Revert "Fix DateTimeOffset.DateTime UTC bug (#7349)"

This reverts commit 33fd92d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-actor akka-persistence api-change serialization
Projects
None yet
Milestone
1.5.29
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb