Merge pull request #1709 from akto-api-security/hotfix/fix_minor_ui_bugs

fixing test run result page
akto-api-security · Nov 11, 2024 · 13e2e61 · 13e2e61
2 parents cf46ff6 + 52d7471
commit 13e2e61
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/apps/dashboard/web/polaris_web/web/src/apps/dashboard/components/layouts/LayoutWithTabs.js b/apps/dashboard/web/polaris_web/web/src/apps/dashboard/components/layouts/LayoutWithTabs.js
@@ -23,7 +23,7 @@ export default function LayoutWithTabs(props){
             onSelect={setCurrentTab}
             tabs={!props.disabledTabs ? props.tabs : props.tabs.filter(obj => !props.disabledTabs.includes(obj.id))}
         >
-            {loading ? <SpinnerCentered/> : props.tabs[current].component }
+            {loading ? <SpinnerCentered/> : (props.tabs[current]?.component || null) }
         </LegacyTabs>
     )
 }
diff --git a/...web/polaris_web/web/src/apps/dashboard/pages/settings/integrations/components/Details.jsx b/...web/polaris_web/web/src/apps/dashboard/pages/settings/integrations/components/Details.jsx
@@ -1,4 +1,4 @@
-import { Button, HorizontalStack, LegacyCard, Link, Text, VerticalStack } from '@shopify/polaris'
+import { Button, HorizontalStack, LegacyCard, VerticalStack } from '@shopify/polaris'
 import React from 'react'
 import LineComponent from './LineComponent'
 

diff --git a/...olaris_web/web/src/apps/dashboard/pages/testing/TestRunResultPage/TestRunResultFlyout.jsx b/...olaris_web/web/src/apps/dashboard/pages/testing/TestRunResultPage/TestRunResultFlyout.jsx
@@ -177,7 +177,7 @@ function TestRunResultFlyout(props) {
                             <Button removeUnderline plain monochrome onClick={() => openTest()}>
                                 <Text variant="headingSm" alignment="start" breakWord>{selectedTestRunResult?.name}</Text>
                             </Button>
-                            {severity.length > 0 ? (issueDetails?.testRunIssueStatus === 'IGNORED' ? <Badge size='small'>Ignored</Badge> : <Box className={`badge-wrapper-${severity.toUpperCase()}`}><Badge size="small" status={observeFunc.getColor(severity)}>{severity}</Badge></Box>) : null}
+                            {(severity && severity?.length > 0) ? (issueDetails?.testRunIssueStatus === 'IGNORED' ? <Badge size='small'>Ignored</Badge> : <Box className={`badge-wrapper-${severity.toUpperCase()}`}><Badge size="small" status={observeFunc.getColor(severity)}>{severity}</Badge></Box>) : null}
                         </div>
                     </Box>
                     <HorizontalStack gap={"2"}>
@@ -394,7 +394,7 @@ function TestRunResultFlyout(props) {
 
     const tabsComponent = (
         <LayoutWithTabs
-            key="tab-comp"
+            key={issueDetails?.id}
             tabs={issueDetails?.id ? [overviewTab,timelineTab,ValuesTab]: [attemptTab]}
             currTab = {() => {}}
         />