moving okta-sso for new id #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TangoBeeAkto
reviewed
Jan 3, 2025
| @@ -367,7 +367,7 @@ public static class OktaConfig extends Config { | |||
|
|
|||
| public OktaConfig() { | |||
| this.configType = ConfigType.OKTA; | |||
| this.id = CONFIG_ID; | |||
| this.id = CONFIG_ID + "_" + this.accountId; | |||
There was a problem hiding this comment.
This won't work because the constructor will be called and the id variable will be initialized before the setAccountId method is called so the value will default to 0.
Ark2307
force-pushed
the
hotfix/fix_okta_sso_integration
branch
from
f26ffae to
66c867d
Compare
notshivansh
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.