-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: authorizing kargo stages to modify argo apps #2921
docs: authorizing kargo stages to modify argo apps #2921
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
==========================================
+ Coverage 49.92% 51.40% +1.48%
==========================================
Files 275 288 +13
Lines 24668 26108 +1440
==========================================
+ Hits 12315 13421 +1106
- Misses 11676 11961 +285
- Partials 677 726 +49 ☔ View full report in Codecov by Sentry. |
I'm not sure I agree with this. It has nothing to do with user permissions. We probably need to carve out a whole separate page for "Argo CD Integration". It can be very light on content for now with a notice that the page is under construction and the real content can, for now, be limited to what you're adding here. |
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
4f203d7
to
e0a6a70
Compare
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Faeka Ansari <faeka6@gmail.com> Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> (cherry picked from commit 011f87a)
Successfully created backport PR for |
closes #2440
I have made the documentation placement for the
kargo.akuity.io/authorized-stage
annotation in "Managing User Permissions" section because imo it is a key component in managing permissions between Kargo and Argo CD.While I also considered options like a dedicated
annotation reference
guide or including it inkey concepts
, I believe current placement is most relevant. Please let me know if this location works or if there's an alternative section recommended.