-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow project scoped generic kubernetes secrets #2975
Conversation
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
+ Coverage 51.40% 52.05% +0.64%
==========================================
Files 288 295 +7
Lines 26108 26695 +587
==========================================
+ Hits 13421 13895 +474
- Misses 11961 12041 +80
- Partials 726 759 +33 ☔ View full report in Codecov by Sentry. |
@krancour generic secret creation and listing those is ready. Till I figure out what to do for updates could you start looking at the backend code? Also do you think its better to re-use the create resource API instead of modifying the create credentials? |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@krancour could you start looking.. I will bring code coverage to threshold |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sorry this took me so long. Overall, this looks fantastic. Test drive went really smoothly. I have some small bits of feedback, that I think are easy to address. In the screenshot above, I was initially thrown off by not seeing any kind of "Add Secret" button. It took me a while to realize that clicking "Add Credentials" would pop up a dialog that could be used for adding generic Secrets as well. I think this could potentially be less confusing if each of the two sections of this page each got their own "Add Credentials" and "Add Secret" buttons. In the same screen shot, upper right, the alt text for the tab says "Credentials". With Secrets being more broad/generic than credentials, I would suggest making the alt text there "Secrets." Credentials are a kind of Secret. (If it's not a problem, I think the URL of the page could also change to end in "/secrets". Two things tripped me up in the screenshot above. The title of the dialog is "Edit Credentials" even when I'm working on a generic Secret. Could it be at all practical to have two separate dialogs? One for creds and one for generic? When editing an existing Secret, not seeing any Last -- a weird one. If I try to add a new key "foobar" above, the new line disappears the moment I hit the second "o" in "foobar". I assume there's some real time validation that keys aren't being duplicated and after hitting that second "o", it looks like I am duplicating "foo" although I wasn't done typing. If I type any other value not staring with the characters of an existing key, everything works fine. I think/hope these are all relatively minor tweaks. As I said, overall, this worked great and did exactly what it's supposed to. |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Great suggestions! @krancour you might want to take a look now, except your last point (in progress) all other review points are addressed. Thanks |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 I promise I'll 👀 the latest changes tomorrow. Thank you for the hard work on this. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
a7d4cd9
to
793f29e
Compare
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
This PR now allows create generic k8s secrets
TODO: