feat(chart): add option for ingress controller terminating ssl with its own cert #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3158 +/- ##
=======================================
Coverage 51.27% 51.27%
=======================================
Files 285 285
Lines 25706 25706
=======================================
Hits 13182 13182
Misses 11824 11824
Partials 700 700 ☔ View full report in Codecov by Sentry. |
hiddeco
approved these changes
Dec 19, 2024
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Dec 20, 2024
…ts own cert (akuity#3158) Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Jan 16, 2025
…ts own cert (akuity#3158) Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2920
cc @hghtwr @tsmalls93 if either of you can verify that your difficulties reported in #2920 are cleared up with this change + setting
api.ingress.tls.usesControllerCert: true, it would be a huge help. 🙏