chore: remove image updater info #3167
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
==========================================
+ Coverage 51.26% 51.40% +0.14%
==========================================
Files 283 288 +5
Lines 25563 26100 +537
==========================================
+ Hits 13104 13416 +312
- Misses 11762 11959 +197
- Partials 697 725 +28 ☔ View full report in Codecov by Sentry. |
api/v1alpha1/warehouse_types.go
Outdated
| // changes. Refer to Image Updater documentation for more details. | ||
| // More info: https://github.com/masterminds/semver#checking-version-constraints | ||
| // changes. |
There was a problem hiding this comment.
This may have been poorly worded by me initially and it may have caused you some confusion.
Image Updater and masterminds/semver are two different things.
We do want to remove anything that refers readers to Image Updater for more info because we're no longer using Image Updater anywhere in Kargo.
masterminds/semver is a library we use for parsing and comparing semantic version strings. (Image Updater happens to use it as well. It's a popular library.)
At any rate... we should keep references to masterminds/semver docs as they're still the definitive source of information for how version constraints work.
There was a problem hiding this comment.
This applies throughout the PR.
There was a problem hiding this comment.
Oh, understood. I interpreted it wrong. Thanks for explaining!
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
fykaa
force-pushed
the
info/semantic-version
branch
from
45d722b to
f829a49
Compare
Signed-off-by: Faeka Ansari <faeka6@gmail.com> (cherry picked from commit a66b421)
|
Successfully created backport PR for |
closes #2833
part of it was merged in #2963