Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5230] Fix bug standalone project hierarchy #5244

Merged

Conversation

ifirmawan
Copy link
Contributor

TODO / Done

Summarize what has been changed / what has to be done in order to finalize the PR.

  • Set loading indicator is false when the program is not found and doesn't have children

Test plan

What tests are necessary to ensure this works or doesn't break anything working

  • Manual test

Manual Test

  • Login as MnE manager
  • Switch only show standalone projects below as true
  • Go to any standalone project
  • Move to project hierarchy

Solved by checking the number of UUIDs and setting loading false when
the program is not found and doesn't have children.
@ifirmawan ifirmawan requested a review from zuhdil March 10, 2023 09:36
@ifirmawan ifirmawan linked an issue Mar 10, 2023 that may be closed by this pull request
@ifirmawan ifirmawan self-assigned this Mar 10, 2023
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 68.162% (-0.004%) from 68.166% when pulling e3ed60f on 5230-bug-project-hierarchy-page-broken-for-standalone-projects into d6a1668 on master.

@ifirmawan ifirmawan added the Bug label Mar 13, 2023
@zuhdil zuhdil merged commit d6aa3b3 into master Mar 15, 2023
@zuhdil zuhdil deleted the 5230-bug-project-hierarchy-page-broken-for-standalone-projects branch March 15, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Project hierarchy page broken for standalone projects
3 participants