Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5255 Upgrade node to 10.24.1 #5256

Merged
merged 2 commits into from
Mar 20, 2023
Merged

#5255 Upgrade node to 10.24.1 #5256

merged 2 commits into from
Mar 20, 2023

Conversation

MichaelAkvo
Copy link
Contributor

TODO / Done

Summarize what has been changed / what has to be done in order to finalize the PR.

  • Update node version
  • Update npm-shrinkwrap.json (updated automatically by npm)
  • Update package.json (updated automatically by npm)

Test plan

What tests are necessary to ensure this works or doesn't break anything working

  • Start and browser RSR

Related to #5255

@MichaelAkvo MichaelAkvo self-assigned this Mar 16, 2023
@MichaelAkvo MichaelAkvo requested a review from zuhdil March 16, 2023 16:14
@coveralls
Copy link
Collaborator

coveralls commented Mar 16, 2023 •
edited
Loading

Coverage Status

Coverage: 68.217%. Remained the same when pulling 0665b28 on bug/5255-node-10.15.0-unavailable into d9706a6 on master.

@MichaelAkvo MichaelAkvo marked this pull request as ready for review March 20, 2023 09:10
@MichaelAkvo MichaelAkvo merged commit 869b5c9 into master Mar 20, 2023
@MichaelAkvo MichaelAkvo deleted the bug/5255-node-10.15.0-unavailable branch March 20, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuhdil zuhdil Awaiting requested review from zuhdil

Assignees

@MichaelAkvo MichaelAkvo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelAkvo @coveralls