Rework HODMD to use BaseService #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the HODMD code, fixes some bugs in it, simplifies it, and makes it work with BaseService. I also add an Azure function and tests for it.
I also make a couple of other changes that came up in the process:
insert-model-measureendpoint was returning the wrong status code when a duplicate was inserted. Now fixed.BaseServiceso that the backend access token is acquired beforeget_service_datais called. This allows one to use the token inget_service_datato make backend calls, which I find handy, and make use of with HODMD.More changes to the models may be coming, but this feels like a good check point to get stuff merged.
Closes #202