Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint for python typing that pastel_factor is a float #30

Merged

Conversation

coderesting
Copy link
Contributor

pastel_factor is currently assumed to be an integer by the type checker.
Changing "0" to "0." fixes this.

@jack89roberts
Copy link
Collaborator

Thanks @coderesting - I'll plan to merge this later this week.

@jack89roberts
Copy link
Collaborator

jack89roberts commented Sep 11, 2023

Actually black doesn't like 0., could you change them to 0.0 (otherwise I can when I get around to this)?

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #30 (cf0f897) into main (9f9f15e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cf0f897 differs from pull request most recent head 00e6161. Consider uploading reports for the commit 00e6161 to get more accurate results

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files           6        6           
  Lines         375      375           
=======================================
  Hits          319      319           
  Misses         56       56           
Files Changed Coverage Δ
distinctipy/__init__.py 100.00% <100.00%> (ø)
distinctipy/distinctipy.py 88.60% <100.00%> (ø)

@jack89roberts jack89roberts merged commit 0ed9c7c into alan-turing-institute:main Sep 18, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants