Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revitalise tests 🧪 #326

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Revitalise tests 🧪 #326

merged 3 commits into from
Oct 24, 2023

Conversation

KristinaUlicna
Copy link
Collaborator

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

  • Brings previously commented tests back to life with pytest.skip or pytest.xfail

List of proposed changes / linked issues & discussions

  • No linked issues here, fixing a temporary test commenting hack from before.

What should a reviewer concentrate their feedback on?

  • 📝 Everything looks OK?

What type of PR is this? (check all applicable)

  • ✅ Test

Added tests?

  • 👍 yes, revitalised old ones

@KristinaUlicna KristinaUlicna self-assigned this Oct 23, 2023
@KristinaUlicna KristinaUlicna added the tests Automated testing for stable main branch label Oct 23, 2023
@KristinaUlicna KristinaUlicna added this to the Merge `dev` -> `main` milestone Oct 23, 2023
@KristinaUlicna KristinaUlicna merged commit 070283c into development Oct 24, 2023
1 check passed
@KristinaUlicna KristinaUlicna deleted the revitalise-tests branch October 24, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crangelsmith crangelsmith crangelsmith approved these changes

Assignees

@KristinaUlicna KristinaUlicna

Labels
tests Automated testing for stable main branch
Projects
None yet
Milestone
Merge `dev` -> `main`
Development

Successfully merging this pull request may close these issues.
2 participants
@KristinaUlicna @crangelsmith