Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename directory from "test" to "testing" #221

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Nov 9, 2024

https://github.com/alan2207/bulletproof-react/blob/master/docs/project-structure.md

The directory name was “test,” so I odified the sample directory name accordingly.
If "testing" is the appropriate name, I would like to update the documentation accordingly.

Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for bulletproof-react-app ready!

Name Link
🔨 Latest commit 03b1346
🔍 Latest deploy log https://app.netlify.com/sites/bulletproof-react-app/deploys/67333e862def8c00078a16e8
😎 Deploy Preview https://deploy-preview-221--bulletproof-react-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alan2207
Copy link
Owner

Hey @y-hsgw , that is a great catch! I prefer calling that folder testing just because it doesn't contain tests but utilities for tests, so you can just update the readme. At the end of the day, you can use whichever you want, it doesn't make a big difference :)

@y-hsgw y-hsgw changed the title Rename directory from "testing" to "test" Rename directory from "test" to "testing" Nov 12, 2024
@y-hsgw
Copy link
Contributor Author

y-hsgw commented Nov 12, 2024

@alan2207
Thank you for your response! I understand now.
I updated the documentation in 567e4b2.

@alan2207 alan2207 merged commit 5cdc208 into alan2207:master Nov 12, 2024
3 of 4 checks passed
@y-hsgw y-hsgw deleted the refactor-rename-test-dir branch November 12, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants