Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configureFonts incorrectly written? #5

Open
milonti opened this issue May 31, 2018 · 1 comment
Open

configureFonts incorrectly written? #5

milonti opened this issue May 31, 2018 · 1 comment

Comments

@milonti
Copy link

milonti commented May 31, 2018

Hello.

I was using this as a part of a project I'm working on, and specifically looking around configureFonts.js
It doesn't seem like you have this file set up correctly. FontFaceObserver is made to take a string for the family, not an array of strings. This as far as I can tell causes all loads to fail when written in this manner.

Shouldn't it be an array of FontFaceObservers that get passed to a mapping function? One observer per font.

@milonti
Copy link
Author

milonti commented May 31, 2018

Also, there's no @font-face rule anywhere in your CSS, so the font load is entirely useless and always fails, even if it was set up correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant