Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add material ui version of report viewer. #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

laskoviymishka
Copy link

Hi, i add new version of report viewer. It base on react material-ui and use rest api to process everything (post params rather then encode them in form and query).

here is some samples
image

image

image

@alanjuden
Copy link
Owner

Hey @laskoviymishka, thanks for sending this in. I've only had a little bit of time to review this. I really like your idea of having the api rather than adding them onto the controller...very cool idea...can't believe I hadn't thought of that yet! 😄

I have been planning for some time to have different HtmlExtension functions that would allow you to target Bootstrap3 vs React vs Generic Styling to match the new Reporting Services layout and any other types...that way, in your UI you can just choose the appropriate function to call that would render the entire control for you.

This may be better off as a separate Example project that would be for the React usage of the control...as I've done separate examples based on the setup of the environments.

I'll probably have some time to check it more thoroughly this weekend.

Thanks again for the ideas.

Alan

@laskoviymishka
Copy link
Author

laskoviymishka commented Apr 20, 2017

Html extension function is just fine, I could extract such function from current implementation.
And also how about idea of having Middleware for report viewer?
Something like

app.UseReports(new ReportOptions { Path, Credentials, Etc}) 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants