Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the TestInit.test_nofilematch test in a tempdir #345

Closed
xiki-tempula opened this issue Jan 8, 2024 · 0 comments · Fixed by #351
Closed

Run the TestInit.test_nofilematch test in a tempdir #345

xiki-tempula opened this issue Jan 8, 2024 · 0 comments · Fixed by #351
Assignees
Labels

Comments

@xiki-tempula
Copy link
Collaborator

The current test is

    def test_nofilematch(self):
        with pytest.raises(ValueError, match="No file has been matched to"):
>           ABFE(
                dir="./",
                prefix="dhdl",
                suffix="xvg",
                T=310,
            )

Which is fine it's own sense but will try to search through all the subfolders in dir="./". So if you run it in your root path '~', it will try to access all the files which might annoy some security people. Once I had time should make a temp dir for this test.

@xiki-tempula xiki-tempula mentioned this issue Mar 24, 2024
@xiki-tempula xiki-tempula linked a pull request Mar 24, 2024 that will close this issue
orbeckst pushed a commit that referenced this issue Apr 1, 2024
)

* Fix #345 
  Run the TestInit.test_nofilematch test in a tempdir
* fix RTD by pinning to py 3.10 for docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants