-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper #328
JOSS paper #328
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 28 28
Lines 1978 1978
Branches 435 435
=======================================
Hits 1954 1954
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Hey @xiki-tempula, thanks for getting this started! How would you like me (and others) to engage? Do you mind if I push directly to this branch as I work on this with you? |
@dotsdl I think you can just commit to the branch. But it would be nice to keep the commit history simple so there won't be a millions of fix typo commit. |
@xiki-tempula understood, thanks. Will do the best I can to avoid commit spam. I think once we're ready to merge we can do it as a squash to avoid adding noise to |
I just wanted to do a status check on this, since I’d been expecting to need to review mid-September…?
Thanks.
…On Aug 22, 2023, 8:17 AM -0700, David L. Dotson ***@***.***>, wrote:
@xiki-tempula understood, thanks. Will do the best I can to avoid commit spam. I think once we're ready to merge we can do it as a squash to avoid adding noise to master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
@dotsdl Do you have any thing to add. I will try to do another update on this later this month. |
@xiki-tempula not at this time, no. Apologies, it's renewals season for me and so I've had to divert attention elsewhere again. I will be able to devote some effort to this late November, so can operate on anything you put in between now and then. Feel free to leave sections you'd prefer I'd write so the load isn't all on you. |
@dotsdl @orbeckst Finally had some time to work on this during the Xmas. The word count should be between 250-1000 and we are currently roughly 900. Do you guys mind have a look? |
* MRS comments Some notes from MRS * Update joss_paper/paper.md Co-authored-by: Zhiyi Wu <zwu@exscientia.co.uk> --------- Co-authored-by: Zhiyi Wu <zwu@exscientia.co.uk>
Thank @mrshirts for the comments.
Do @mrshirts mind to also add yourself to the relevant section in the |
@xiki-tempula sorry for the delay, I haven't forgotten about this. Will get you a proper review as soon as I can, and will add in content if I see obvious gaps. |
@dotsdl Thanks! |
What's the current status on this? It would be nice to get this submitted in the next month or so - I can allocate some time to help get it happen. How can I help? |
Thanks for the reminder. Let's try to get this ready by the end of the month. |
@xiki-tempula can you please have a look at final JOSS todos openjournals/joss-reviews#6934 (comment) — we basically need a new release for alchemlyb #389. |
Just as an update: We need to go through a final checklist (see openjournals/joss-reviews#6934 (comment) ) but at the moment the process is held up by zenodo not archiving our 2.3.2 release #393 . |
The zenodo archiving issue was fixed a few days ago, just waiting for JOSS. |
The last request from the JOSS editor is to add a CITATION.cff file #394 so that the author names in the zenodo archive correspond to the paper openjournals/joss-reviews#6934 (comment) when we make a new release #396 . In PR #395 I am adding the citation file. Please check the PR and let me know as soon as possible if any changes need to be made. |
* add CITATION.cff file * close #394 * add all AUTHORS with ORCIDs and affiliation (as far as they are confirmed); order based on AUTHORS * add alchemlyb PIs * add contributors that were listed in JOSS paper acknowledgements (PR #328) but had NOT been listed in AUTHORS (inserted in chronological order) * only add emails for maintainers/PIs * add Software Heritage Identifier * add paper citation section for MBAR, decorrelation, and preliminary citation for JOSS paper #71 * add one new contributor (from recent PR #381) to AUTHORS and CITATIONS.cff
We made a 2.4.0 release #396 and we now have a zenodo archive with a nicely formatted authors list with ORCIDs at https://doi.org/10.5281/zenodo.13774657 ... this should be it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have everything:
- release 2.4.1
- zenodo DOI 10.5281/zenodo.13799342
Possibly one update to Acknowledgements so that everyone in the CITATION.cff (and on zenodo) is also somehow named in the paper.
- acknowledging recent additions to 2.4.0 and 2.4.1 release (after the review of the manuscript) - approved in #328 (comment)
We should be done ... openjournals/joss-reviews#6934 (comment) |
The handling editor recommended the paper for acceptance & publication openjournals/joss-reviews#6934 (comment). 🎉 |
Thanks so much @orbeckst for shepherding this through and herding all the cats! 🐈 |
We're not there yet, sigh.... |
Paper is published https://joss.theoj.org/papers/10.21105/joss.06934 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 Thank you everyone for your great work! |
With the paper published I will close the PR. We do not need to merge it. |
Let's not delete the branch and keep it around, in case we want to recycle anything. |
SOOO much work and so many iterations @orbeckst; thank you for shepherding it through! |
@orbeckst I have made a quick draft of the JOSS paper.
I have only written the summary and the Statement of need and left other things as the template.
The guide line is here https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography
Co-authors
Substantial contributors to alchemlyb are invited to become authors of the paper. See #328 (comment) below for details.
Building the PDF
As part of the GitHub actions workflow, a full PDF version of the paper is built and you can download it as an artifact.
If you want to build the PDF locally you can use
pandoc