Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #328

Closed
wants to merge 108 commits into from
Closed

JOSS paper #328

wants to merge 108 commits into from

Conversation

xiki-tempula
Copy link
Collaborator

@xiki-tempula xiki-tempula commented Jul 8, 2023

@orbeckst I have made a quick draft of the JOSS paper.
I have only written the summary and the Statement of need and left other things as the template.
The guide line is here https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography

Co-authors

Substantial contributors to alchemlyb are invited to become authors of the paper. See #328 (comment) below for details.

Building the PDF

As part of the GitHub actions workflow, a full PDF version of the paper is built and you can download it as an artifact.

If you want to build the PDF locally you can use pandoc

pandoc --citeproc -o paper.pdf  paper.md

@xiki-tempula xiki-tempula linked an issue Jul 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (8a361d5) to head (27caba8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          28       28           
  Lines        1978     1978           
  Branches      435      435           
=======================================
  Hits         1954     1954           
  Misses          2        2           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl
Copy link
Member

dotsdl commented Aug 21, 2023

Hey @xiki-tempula, thanks for getting this started!

How would you like me (and others) to engage? Do you mind if I push directly to this branch as I work on this with you?

@xiki-tempula
Copy link
Collaborator Author

@dotsdl I think you can just commit to the branch. But it would be nice to keep the commit history simple so there won't be a millions of fix typo commit.

@dotsdl
Copy link
Member

dotsdl commented Aug 22, 2023

@xiki-tempula understood, thanks. Will do the best I can to avoid commit spam. I think once we're ready to merge we can do it as a squash to avoid adding noise to master.

@davidlmobley
Copy link

davidlmobley commented Oct 17, 2023 via email

@xiki-tempula
Copy link
Collaborator Author

@dotsdl Do you have any thing to add. I will try to do another update on this later this month.

@dotsdl
Copy link
Member

dotsdl commented Oct 31, 2023

@xiki-tempula not at this time, no.

Apologies, it's renewals season for me and so I've had to divert attention elsewhere again. I will be able to devote some effort to this late November, so can operate on anything you put in between now and then. Feel free to leave sections you'd prefer I'd write so the load isn't all on you.

@xiki-tempula
Copy link
Collaborator Author

@dotsdl @orbeckst Finally had some time to work on this during the Xmas. The word count should be between 250-1000 and we are currently roughly 900. Do you guys mind have a look?
I have also add a new github action that renders the draft into a pdf and it shall be available as artifact of the corresponding action (.github/workflows/draft-pdf.yml / Paper Draft (push) ).

mrshirts and others added 4 commits December 30, 2023 19:05
* MRS comments

Some notes from MRS

* Update joss_paper/paper.md

Co-authored-by: Zhiyi Wu <zwu@exscientia.co.uk>

---------

Co-authored-by: Zhiyi Wu <zwu@exscientia.co.uk>
@xiki-tempula
Copy link
Collaborator Author

Thank @mrshirts for the comments.

  • The alchemcial-analysis is only mentioned in one paragraph in the Statement of need section.
  • The big paragraph of ABFE is removed and one sentence has been added to the end of how to expand the solvation free energy to ABFE.
  • I didn't make a figure for solvation free energy as it is kind of awkward thing to discuss. If I only give a high-level description like I did here. Then I don't really need a figure. If I dig into more detail then it might not really be necessary as the reader might not expect that in JOSS.

Do @mrshirts mind to also add yourself to the relevant section in the Acknowledgements, please? Thank you.

@dotsdl
Copy link
Member

dotsdl commented Jan 19, 2024

@xiki-tempula sorry for the delay, I haven't forgotten about this. Will get you a proper review as soon as I can, and will add in content if I see obvious gaps.

@xiki-tempula
Copy link
Collaborator Author

@dotsdl Thanks!

@mrshirts
Copy link

mrshirts commented Apr 6, 2024

What's the current status on this? It would be nice to get this submitted in the next month or so - I can allocate some time to help get it happen. How can I help?

@orbeckst
Copy link
Member

orbeckst commented Apr 6, 2024

Thanks for the reminder.

Let's try to get this ready by the end of the month.

@orbeckst orbeckst mentioned this pull request Aug 19, 2024
5 tasks
@orbeckst
Copy link
Member

@xiki-tempula can you please have a look at final JOSS todos openjournals/joss-reviews#6934 (comment) — we basically need a new release for alchemlyb #389.

@orbeckst
Copy link
Member

orbeckst commented Sep 5, 2024

Just as an update: We need to go through a final checklist (see openjournals/joss-reviews#6934 (comment) ) but at the moment the process is held up by zenodo not archiving our 2.3.2 release #393 .

@orbeckst
Copy link
Member

orbeckst commented Sep 9, 2024

The zenodo archiving issue was fixed a few days ago, just waiting for JOSS.

@orbeckst
Copy link
Member

The last request from the JOSS editor is to add a CITATION.cff file #394 so that the author names in the zenodo archive correspond to the paper openjournals/joss-reviews#6934 (comment) when we make a new release #396 .

In PR #395 I am adding the citation file. Please check the PR and let me know as soon as possible if any changes need to be made.

orbeckst added a commit that referenced this pull request Sep 16, 2024
* add CITATION.cff file
* close #394
* add all AUTHORS with ORCIDs and affiliation (as far as they are confirmed);   order based on AUTHORS
* add alchemlyb PIs
* add contributors that were listed in JOSS paper acknowledgements (PR #328) but had NOT been listed in AUTHORS (inserted in chronological order)
* only add emails for maintainers/PIs
* add Software Heritage Identifier
* add paper citation section for MBAR, decorrelation, and preliminary citation for JOSS paper #71 
* add one new contributor (from recent PR #381) to AUTHORS and CITATIONS.cff
@orbeckst
Copy link
Member

We made a 2.4.0 release #396 and we now have a zenodo archive with a nicely formatted authors list with ORCIDs at https://doi.org/10.5281/zenodo.13774657 ... this should be it.

@orbeckst orbeckst changed the title Draft for a JOSS paper JOSS paper Sep 17, 2024
@orbeckst
Copy link
Member

We were asked to ensure that the zenodo archive and the paper have the same title, so this requires #402 and making a quick 2.4.1 release #403 .

@orbeckst orbeckst added the paper label Sep 19, 2024
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have everything:

Possibly one update to Acknowledgements so that everyone in the CITATION.cff (and on zenodo) is also somehow named in the paper.

joss_paper/paper.md Outdated Show resolved Hide resolved
- acknowledging recent additions to 2.4.0 and 2.4.1 release (after the review of the manuscript)
- approved in #328 (comment)
@orbeckst
Copy link
Member

We should be done ... openjournals/joss-reviews#6934 (comment)

@orbeckst
Copy link
Member

The handling editor recommended the paper for acceptance & publication openjournals/joss-reviews#6934 (comment). 🎉

@dotsdl
Copy link
Member

dotsdl commented Sep 23, 2024

Thanks so much @orbeckst for shepherding this through and herding all the cats! 🐈

@orbeckst
Copy link
Member

We're not there yet, sigh....

@orbeckst
Copy link
Member

Paper is published https://joss.theoj.org/papers/10.21105/joss.06934

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

Thank you everyone for your great work!

@orbeckst
Copy link
Member

With the paper published I will close the PR. We do not need to merge it.

@orbeckst orbeckst closed this Sep 26, 2024
@orbeckst
Copy link
Member

Let's not delete the branch and keep it around, in case we want to recycle anything.

@mrshirts
Copy link

SOOO much work and so many iterations @orbeckst; thank you for shepherding it through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS paper