Fix #345 #351
Merged
Fix #345 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 98.71% 98.82% +0.10%
==========================================
Files 28 28
Lines 1873 1873
Branches 405 405
==========================================
+ Hits 1849 1851 +2
Misses 2 2
+ Partials 22 20 -2 ☔ View full report in Codecov by Sentry. |
orbeckst
requested changes
Mar 30, 2024
devtools/conda-envs/test_env.yaml
Outdated
| @@ -24,5 +24,5 @@ dependencies: | |||
| - sphinx_rtd_theme | |||
|
|
|||
| - pip: | |||
| - alchemtest @ https://github.com/alchemistry/alchemtest/archive/master.zip | |||
| - alchemtest @ git+https://github.com/xiki-tempula/alchemtest.git@feat_main | |||
| @@ -50,7 +50,7 @@ jobs: | |||
| with: | |||
| environment-file: devtools/conda-envs/test_env.yaml | |||
| environment-name: test | |||
| extra-specs: | | |||
| create-args: | | |||
There was a problem hiding this comment.
Is this also being fixed in #346 ?
|
Remove the py3.12 support now. I will add the py3.12 support in another PR, where I think I will update the versioneer. I would hope to do the same sort of updating to the cookie cutter here but I guess that will generate big merge conflict for #348 |
xiki-tempula
commented
Mar 31, 2024
| channels: | ||
| dependencies: | ||
| # Base depends | ||
| - python=3.10 |
There was a problem hiding this comment.
Pin it to a python version so it would not break just due to some python update.
orbeckst
approved these changes
Apr 1, 2024
orbeckst
deleted the
345-run-the-testinittest_nofilematch-test-in-a-tempdir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #345