-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CITATION.cff file #395
Conversation
orbeckst
commented
Sep 11, 2024
•
edited
Loading
edited
- close create CFF citation file #394
- add all AUTHORS with ORCIDs and affiliation (as far as they are confirmed)
- order based on AUTHORS
- add alchemlyb PIs
- add contributors that were listed in JOSS paper acknowledgements (PR JOSS paper #328) but had NOT been listed in AUTHORS (inserted in chronological order)
- only add emails for maintainers/PIs
- add Software Heritage Identifier
- add paper citation section for MBAR, decorrelation, and JOSS paper JOSS paper #328
- add one new contributor (from recent PR Moving average #381 ) to AUTHORS and CITATIONS.cff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if you want to make any changes to your information.
- given-names: Travis | ||
family-names: Jensen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trje3733 do you want to add any additional information here?
- given-names: Dominik | ||
family-names: Wille | ||
affiliation: Freie Universität Berlin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harlor do you want to add any additional information here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 28 28
Lines 1981 1981
Branches 435 435
=======================================
Hits 1957 1957
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Note to self: merge (no squash merge) so that individual commits remain visible in the history in case there are questions about decisions. |
Hello @orbeckst, thank you for creating the cff file. It seems my affiliation in the file is not correct. It was listed as UC Irvine rather than the UNC one. I'm wondering if it's possible to change? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hl2500 thanks for checking, apologies for my mistake. I fixed your affiliation (see below).
@dotsdl @davidlmobley @mrshirts could you please have a look at the author list here by the end of Monday 9/16? I would like to finish the JOSS paper and this is the very last thing that's needed. If you need more time please let me know. If I don't hear anything else by Tuesday morning I'll take this as tacit agreement and we'll make a release #396 and finish the paper #71. |
- generated with https://bit.ly/cffinit - authors and order from AUTHORS - affiliations and ORCID from JOSS paper - emails from paper or individuals Co-authored-by: David L. Dotson <dotsdl@gmail.com>
- inferred DOI from proof - assume final acceptance in 2024...
- added David Mobley @davidlmobley (original conception and design of alchemlyb) - added Michael Shirts @mrshirts (original conception and design of alchemlyb)
- CHANGES: bump to 2.3.3 - add reminder to AUTHORS to also update CITATION.cff
Added all authors that were mentioned in the Acknowledgements of the JOSS paper but were not in AUTHORS - Wei-Tse Hsu @wehs7661 (2020) for code clean-up in a732380 - Jan Janssen @jan-janssen (2022) for creating the conda-forge package - Shujie Fan @VOD555 (2022) for initial code for fractional equilibration time - Helmut Carter @helmutcarter (2024) for doc fix in #356
LGTM! |
This looks good to me! |
@xiki-tempula given that you merged PR #381 please update on this PR
Thanks. |
AUTHORS entry had been forgotten in PR #381