fix: don't show error view when cancelling oauth #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphilipson
requested review from
moldy530,
rthomare,
dancoombs and
mokok123
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rthomare
reviewed
Oct 17, 2024
dphilipson
force-pushed
the
dp/cancel-oauth-error
branch
from
8f17322
to
7047540
Compare
moldy530
previously approved these changes
Nov 11, 2024
dphilipson
force-pushed
the
dp/cancel-oauth-error
branch
from
7047540
to
5441bb5
Compare
|
hmmm aight so the site is failing to deploy consistently which makes me wonder something funky is happening in main. will take a look |
dphilipson
force-pushed
the
dp/cancel-oauth-error
branch
2 times, most recently
from
9df9a98
to
34185de
Compare
dphilipson
force-pushed
the
dp/cancel-oauth-error
branch
from
34185de
to
6260689
Compare
This is an intentional action from the user and not an error. Instead, just return to the main screen.
dphilipson
force-pushed
the
dp/cancel-oauth-error
branch
from
6260689
to
ff9a780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intentional action from the user and not an error. Instead, just return to the main screen.
PR-Codex overview
This PR focuses on enhancing the OAuth flow in the
CompletingOAuthcomponent by adding error handling for cancelled OAuth processes and updating the dependencies.Detailed summary
@account-kit/signeras a new dependency.OauthCancelledErrorfrom@account-kit/signer.oauthWasCancelledto handle cancelled OAuth scenarios.useEffecthook to includeoauthWasCancelled.ConnectionErrorcomponent.