Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rn): clean things up so they're more digestable #1134

Open
wants to merge 1 commit into
base: moldy/rn-base
Choose a base branch
from

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Nov 6, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on refactoring the account-kit/rn-signer codebase, enhancing the RNSignerClient functionality, and updating the Android integration for better key management and security protocols. It also modifies example usage and improves configuration files.

Detailed summary

  • Removed NativeTEKStamper and replaced with RNSignerClient.
  • Updated package.json dependencies.
  • Added new files for HPKE key management in Android.
  • Enhanced .env setup instructions in README.md.
  • Modified Metro configuration to include additional watch folders.
  • Updated yarn.lock with new package versions.
  • Refactored methods in NativeTEKStamperModule for better clarity and security.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 2:25am
aa-sdk-ui-demo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 2:25am

Copy link
Collaborator Author

moldy530 commented Nov 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@moldy530 moldy530 force-pushed the moldy/rn-cleanup branch 3 times, most recently from fecba35 to 30d8d27 Compare November 6, 2024 21:59
@moldy530 moldy530 force-pushed the moldy/rn-cleanup branch 2 times, most recently from e3026cb to 27375ff Compare November 7, 2024 19:21
Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some Kotlin nitpicks, but should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants