-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rn): clean things up so they're more digestable #1134
base: moldy/rn-base
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fecba35
to
30d8d27
Compare
4dcf02b
to
5c58383
Compare
30d8d27
to
ca311b3
Compare
ca311b3
to
e1e5a45
Compare
5c58383
to
9819166
Compare
e3026cb
to
27375ff
Compare
27375ff
to
0190ffc
Compare
0190ffc
to
922ff0e
Compare
9819166
to
e283195
Compare
922ff0e
to
a048e36
Compare
ef78e3a
to
9d7842c
Compare
e283195
to
928bec5
Compare
473b499
to
65140ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some Kotlin nitpicks, but should be good to go.
account-kit/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/TEKManager.kt
Outdated
Show resolved
Hide resolved
account-kit/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/KeyExtensions.kt
Outdated
Show resolved
Hide resolved
account-kit/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/TEKManager.kt
Outdated
Show resolved
Hide resolved
account-kit/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/TEKManager.kt
Outdated
Show resolved
Hide resolved
928bec5
to
ee03d62
Compare
65140ac
to
5cd9e60
Compare
5cd9e60
to
2dfdcfd
Compare
2dfdcfd
to
c740b71
Compare
ee03d62
to
95f28d0
Compare
c740b71
to
de9be14
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on refactoring the
account-kit/rn-signer
codebase, enhancing theRNSignerClient
functionality, and updating the Android integration for better key management and security protocols. It also modifies example usage and improves configuration files.Detailed summary
NativeTEKStamper
and replaced withRNSignerClient
.package.json
dependencies..env
setup instructions inREADME.md
.yarn.lock
with new package versions.NativeTEKStamperModule
for better clarity and security.