Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix doc gen dependency graph #1146

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: fix doc gen dependency graph #1146

merged 1 commit into from
Nov 12, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Nov 12, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing build commands and task configurations across various JSON files, particularly for the vercel.json and package.json files. It introduces new build scripts, modifies existing ones, and updates task dependencies.

Detailed summary

  • Added buildCommand in examples/ui-demo/vercel.json.
  • Updated installCommand and buildCommand in site/vercel.json.
  • Introduced new build task in examples/ui-demo/turbo.json.
  • Renamed build step in .github/workflows/on-pull-request.yml to Build Libraries.
  • Updated run command to yarn build:libs in the same workflow.
  • Modified docs:gen command to use node instead of npx in multiple package.json files.
  • Changed build command in the main package.json to yarn build:libs.
  • Introduced build:demo, build:site, and build:examples scripts in the main package.json.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:36pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:36pm

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @moldy530 and the rest of your teammates on Graphite Graphite

site/vercel.json Outdated
Comment on lines 2 to 3
"installCommand": "cd .. && yarn install --ignore-engines",
"buildCommand": "cd .. && yarn build:base",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanna make sure all of this runs from the root. I will look into updating the settings to always operate from root and correctly deploy the files from site/dist later

"build:base": "turbo run build --filter=!embedded-accounts-quickstart --filter=!ui-demo",
"build:dev": "yarn build:base --filter=!docs",
"build:ci": "yarn build:base && yarn lint:write",
"build": "yarn build:libs",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for backwards compat, I guess I could just merge this and build:libs, but I wanted the separation just to be explicit in the CI script

@moldy530
Copy link
Collaborator Author

hmmmm the test failure here is passing locally -.-

dphilipson
dphilipson previously approved these changes Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants