-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix doc gen dependency graph #1146
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
029a1d1
to
6339cb2
Compare
6339cb2
to
ca8bead
Compare
ca8bead
to
cd51eeb
Compare
site/vercel.json
Outdated
"installCommand": "cd .. && yarn install --ignore-engines", | ||
"buildCommand": "cd .. && yarn build:base", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wanna make sure all of this runs from the root. I will look into updating the settings to always operate from root and correctly deploy the files from site/dist
later
cd51eeb
to
f792d97
Compare
f792d97
to
a24e84c
Compare
a24e84c
to
ec7b62b
Compare
ec7b62b
to
ff9ad64
Compare
"build:base": "turbo run build --filter=!embedded-accounts-quickstart --filter=!ui-demo", | ||
"build:dev": "yarn build:base --filter=!docs", | ||
"build:ci": "yarn build:base && yarn lint:write", | ||
"build": "yarn build:libs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for backwards compat, I guess I could just merge this and build:libs
, but I wanted the separation just to be explicit in the CI script
hmmmm the test failure here is passing locally -.- |
ff9ad64
to
fc1dbcf
Compare
fc1dbcf
to
7330b51
Compare
7330b51
to
989d18c
Compare
989d18c
to
9077dd2
Compare
9077dd2
to
c9f3e56
Compare
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing build commands and task configurations across various JSON files, particularly for the
vercel.json
andpackage.json
files. It introduces new build scripts, modifies existing ones, and updates task dependencies.Detailed summary
buildCommand
inexamples/ui-demo/vercel.json
.installCommand
andbuildCommand
insite/vercel.json
.build
task inexamples/ui-demo/turbo.json
..github/workflows/on-pull-request.yml
toBuild Libraries
.run
command toyarn build:libs
in the same workflow.docs:gen
command to usenode
instead ofnpx
in multiplepackage.json
files.build
command in the mainpackage.json
toyarn build:libs
.build:demo
,build:site
, andbuild:examples
scripts in the mainpackage.json
.