chore: update build scripts to produce more reliable caching #1150
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
dphilipson and
linnall
as code owners
moldy530
force-pushed
the
moldy/cache-generated-code
branch
from
157b4fd
to
1853d40
Compare
moldy530
force-pushed
the
moldy/cache-generated-code
branch
3 times, most recently
from
6f8a5d3
to
bdd158d
Compare
moldy530
commented
Nov 13, 2024
| @@ -38,7 +38,6 @@ | |||
| "prebuild": "npx tsx ./inject-version.ts", | |||
| "dev": "storybook dev", | |||
| "build": "yarn clean && yarn build:esm && yarn build:types", | |||
| "build:dev": "lerna watch --scope='@account-kit/react' --include-dependencies -- lerna run build --scope=@account-kit/react", | |||
There was a problem hiding this comment.
this is now handled correctly by turbo
moldy530
commented
Nov 13, 2024
| "extends": ["//"], | ||
| "tasks": { | ||
| "generate": { | ||
| "env": ["OPENAI_API_KEY"], |
There was a problem hiding this comment.
used when linting the output of the generate
moldy530
commented
Nov 13, 2024
| "dependsOn": ["^build"], | ||
| "persistent": true, | ||
| "cache": false, | ||
| "interruptible": true |
There was a problem hiding this comment.
this doesn't get hot reloaded when packages change, so this one has to be restarted by turbo
moldy530
force-pushed
the
moldy/cache-generated-code
branch
from
bdd158d
to
46463d0
Compare
7 tasks
dphilipson
approved these changes
Nov 14, 2024
Merge activity
|
# Description This PR updates the generate script for smart contracts to also lint the code generated because right now everytime you run build it produces unlinted code. This results in the cache being consistently busted for this package but also results in unlinted code being generated locally on each build which is a bit annoying. # Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the development environment by adding new `dev` tasks to various `turbo.json` files, updating GitHub workflows to include an `OPENAI_API_KEY`, and modifying scripts to improve the build and generation processes. ### Detailed summary - Added `dev` tasks in `site/turbo.json`, `account-kit/react/turbo.json`, `examples/ui-demo/turbo.json`, and `account-kit/smart-contracts/turbo.json`. - Updated GitHub workflows to include `OPENAI_API_KEY`. - Modified `package.json` to add `dev:ui` and `dev:docs` scripts. - Enhanced `generate` script in `account-kit/smart-contracts/package.json` to include linting. - Updated `yarn.lock` to include `dotenv-cli` and its dependencies. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
moldy530
force-pushed
the
moldy/cache-generated-code
branch
from
46463d0
to
155d1fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the generate script for smart contracts to also lint the code generated because right now everytime you run build it produces unlinted code. This results in the cache being consistently busted for this package but also results in unlinted code being generated locally on each build which is a bit annoying.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on enhancing the development configurations across various
turbo.jsonfiles, introducing new tasks, and updating workflow configurations to integrateOPENAI_API_KEY. It also modifies package scripts to include linting for generated files and adds thedotenv-clidependency.Detailed summary
devtasks in multipleturbo.jsonfiles with specific dependencies and settings..github/workflows/on-pull-request.ymland.github/workflows/publish-package.ymlto includeOPENAI_API_KEY.package.jsonscripts to include linting for generated files.dotenv-clidependency inpackage.json.yarn.lockto reflect the new dependency.