feat: oauth add passkey after signup (popup flow) #1151
+26
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies change
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
moldy530
reviewed
Nov 14, 2024
moldy530
reviewed
Nov 14, 2024
|
|
||
| useNewUserSignup(handleSignup, isConnected); |
There was a problem hiding this comment.
this solves a race condition where an on success handler would set the step to complete and close the modal that was just opened. This makes sure that all handlers complete we're done with the setup flow prior to add passkey
moldy530
reviewed
Nov 14, 2024
Co-authored-by: Michael Moldoveanu <michael.moldoveanu@alchemy.com>
linnall
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a new user signup event in the
AlchemySignerand updates various components to handle this event, alongside some refactoring in theuseAuthModaland related hooks.Detailed summary
newUserSignupevent toAlchemySignerClientEvents.newUserSignupon successful user signup inAlchemySignerWebClient.closeAuthModalinuseAuthModalto improve readability.CompletingOAuthto simplify auth step setting.AuthModalto handle signup logic withuseNewUserSignup.