fix: [CL-009] address allowlist can be set independently of spend limits #280
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 29cb64f |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 4,814 | 5,239 | 19,762 | 43,913 |
-| AllowlistModule | 9,903 | 9,930 | 14,673 | 39,222 |
+| AllowlistModule | 9,553 | 9,580 | 15,023 | 39,572 |
| ExecutionInstallDelegate | 5,694 | 5,740 | 18,882 | 43,412 |
| ModularAccount | 21,971 | 28,654 | 2,605 | 20,498 |
| NativeFunctionDelegate | 434 | 461 | 24,142 | 48,691 |
| NativeTokenLimitModule | 4,258 | 4,285 | 20,318 | 44,867 |
| PaymasterGuardModule | 1,797 | 1,824 | 22,779 | 47,328 |
| SemiModularAccountBytecode | 23,273 | 29,956 | 1,303 | 19,196 |
| SemiModularAccountStorageOnly | 23,767 | 30,450 | 809 | 18,702 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,000 | 2,027 | 22,576 | 47,125 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 |Code coverage:
|
Overview
Detailed findings
|
Overview
Detailed findings
|
adamegyed
reviewed
Nov 8, 2024
| setAddressAllowlist(entityId, input.target, true, input.hasSelectorAllowlist); | ||
| setAddressAllowlist( | ||
| entityId, input.target, true, input.hasSelectorAllowlist, input.hasERC20SpendLimit | ||
| ); | ||
| updateLimits(entityId, input.target, input.hasERC20SpendLimit, input.erc20SpendLimit); |
There was a problem hiding this comment.
Will this line do a duplicate write?
There was a problem hiding this comment.
not compared to the original, hasSelectorAllowlist and hasERC20SpendLimit are bools packed into the same storage slot
howydev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.