Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.0: change in tagging convention? 🤔 #488

Open
kloczek opened this issue Jul 1, 2024 · 8 comments
Open

2.2.0: change in tagging convention? 🤔 #488

kloczek opened this issue Jul 1, 2024 · 8 comments

Comments

@kloczek
Copy link

kloczek commented Jul 1, 2024

Looks like with recent version has been changed tagging convention from 'gmpy2-<version_with_dots>togmpy2_<version_with_underscores>`.
Is it only mistake or from now it will be new tagging convention?
I'm asking because my automation relies on exact convention on processing new release email notifications.

@casevh
Copy link
Collaborator

casevh commented Jul 1, 2024

It was a mistake. What is the best option? Create a new tag with dots and leave both tags, or create the new tag and delete the old one (trying to do a rename)?

@kloczek
Copy link
Author

kloczek commented Jul 1, 2024

Best to be hones would be just <version.with.dots> or v<version.with.dots> because in autogenerated tar ball base directory is automatically generated out of <repo-name>-<git-tag> and if in tag is used on the begging v it is skipped (to make easier branching with <version.with.dots> on v<version.with.dots> to branch some version + some critical changes).

@casevh
Copy link
Collaborator

casevh commented Jul 2, 2024

Is it okay to just create a tag 2.2.0 and leave the old tag as-is? There haven't been any code changes.

@skirpichev
Copy link
Contributor

Perhaps, it might be a good idea to automate release process. In the diofant project I just do git push origin v1.2.3, that's all.

@skirpichev
Copy link
Contributor

BTW, I'm not sure, that @casevh has required permissions for this repository...

@casevh
Copy link
Collaborator

casevh commented Jul 21, 2024

I have tagged v2.2.1 and released on PyPi.

@skirpichev
Copy link
Contributor

Probably, this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants