Avoid OverflowError in mpz.__rshift__() #525
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
no-overflow-rshift-524
branch
from
7875018
to
50641b6
Compare
|
@casevh, second patch removes It's possible to implement this pr in other way, but I think it triggers a bug in the patch. I think that proper support for 64-bit mp_bitcnt_t on win64 1) requires a more work, 2) we should submit patch to the upstream first. |
|
What bug is triggered in the mp_bitcnt_t patch? A previous bug that I reported upstream was fixed within a few days. |
See failed job: https://github.com/aleaxit/gmpy/actions/runs/11379818079/job/31657941881 It's on Windows, I can't reproduce this. I guess, mpz_fdiv_q_2exp() make some assumptions on max value of the last argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #524