Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #499

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Misc fixes #499

merged 4 commits into from
Jul 26, 2024

Conversation

This method rather should use mpfr_set_q with MPFR_RNDN
to reproduce numbers.Rational.__float__().

Closes aleaxit#498
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (224745b) to head (44e879d).
Report is 37 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   85.52%   85.60%   +0.07%     
==========================================
  Files          50       50              
  Lines       11656    11650       -6     
  Branches     2202     2201       -1     
==========================================
+ Hits         9969     9973       +4     
+ Misses       1687     1677      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casevh casevh merged commit 7bd27fe into aleaxit:master Jul 26, 2024
11 checks passed
@casevh
Copy link
Collaborator

casevh commented Jul 26, 2024

Thanks for all the clean-up.

@skirpichev skirpichev deleted the misc branch July 26, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment