fix: When a Grammar combines flags with passthrough args, see if an unrecognized flag may be treated as a positional argument

[boblail]

Issue

Given a grammar like this:

var cli struct {
        Args []string `arg:"" optional:"" passthrough:""`
}

The first positional argument implies that it was preceded by --, so subsequent flags are not parsed.

If Kong parses cli 1 --unknown 3, it will populate Args with []string{"1", "--unknown", "3"}.
However, if Kong parses cli --unknown 2 3, it will fail saying that --unknown is an unrecognized flag.

Proposal

This commit changes the parser so that if an unknown flag could be treated as the first passthrough argument, it is.

After this change, if Kong parses cli --unknown 2 3, it will populate Args with []string{"--unknown", "2", "3"}.

[boblail]

To bypass the linter error:

context.go:350:1: Function name: trace, Cyclomatic Complexity: 47, Halstead Volume: 4627.00, Maintainability Index: 18 (maintidx)

Would you prefer I extracted something from trace instead? Or reworked it to not have a nested if?

... maybe like

case FlagToken:
	if err := c.parseFlag(flags, token.String()); err == nil {
		// Flag was parsed successfully.
	} else if isUnknownFlagError(err) && positional < len(node.Positional) && node.Positional[positional].Passthrough {
		c.scan.Pop()
		c.scan.PushTyped(token.String(), PositionalArgumentToken)
	} else {
		return err
	}

[alecthomas]

It's fine, the linters are just guides, I usually disable them as necessary. FYI you can also just use //nolint:maintidx on the offending line.

[alecthomas]

Thanks!