Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When replaying multiple, only send unique records to retry topic #61

Open
MitchelNijdam-Rockstars opened this issue Nov 15, 2019 · 0 comments
Labels
enhancement New feature or request idea

Comments

@MitchelNijdam-Rockstars
Copy link
Collaborator

MitchelNijdam-Rockstars commented Nov 15, 2019

When for whatever reason there are two records in DLQ for the same original kafka record (that is, same key & value & kafkatimestamp & original offset), while replaying it doesn't make sense to put duplicate records on the retry topic.

So, when replaying, deduplicate first. This can be either default behavior or API parameter ...?unique=true.

In the response of replay endpoint, might be good to show that certain messages were not send because of duplicate, e.g.:

    "replayed": [
        {
            "originalOffset": 23629,
            "replayedOffset": 1
        }
    ],
    "ignored": [
        {
            "originalOffset": 23630,
            "reason": "duplicate of 23629"
        }
    ],...
@MitchelNijdam-Rockstars MitchelNijdam-Rockstars added enhancement New feature or request idea labels Nov 15, 2019
@MitchelNijdam-Rockstars MitchelNijdam-Rockstars changed the title When replay all, only send unique records to retry topic When replaying multiple, only send unique records to retry topic Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea
Projects
None yet
Development

No branches or pull requests

1 participant