Display fullpath of file in statusbar when hovering on recent file menu item #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diepfote
force-pushed
the
display-fullpath-on-recent-menu-item-hover
branch
2 times, most recently
from
be8ab3d to
6e0f985
Compare
diepfote
force-pushed
the
display-fullpath-on-recent-menu-item-hover
branch
from
6e0f985 to
838c508
Compare
|
The behavior is correct now, but aside from some minor styling issues I see you retrieve the path data from the tooltip. Makes sense, but I'd like to have this mechanism replace the tooltip :) I'm anxious to get 0.8.0 out there, so I think for now it's better to revisit this when I've refactored the document/tab data structure. |
|
I found it to be the least messy way to retrieve the filename. |
alexandervdm
force-pushed
the
master
branch
2 times, most recently
from
4975d07 to
0b204f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where you thinking of something like this? #92 (comment)