Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stencil for hiding initially invisible tiles on high resolution #427

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

roginvs
Copy link
Contributor

@roginvs roginvs commented Nov 14, 2024

This PR adds an overlay to hide parts of the map which should not be visible in the original game resolution. It is achieved by traversing adjacent tiles starting from center tile and marking what parts of the screen are visible.

Before
image

After
image

It is using ddraw.ini option:

[Main]
HiResMode=1

Fixes #384

auto screen_diff = get_screen_diff();

while (!tiles_to_visit.empty()) {
auto tileInfo = tiles_to_visit.back();
Copy link
Contributor Author

@roginvs roginvs Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question to C++ gurus: do we copy element (which is struct) here or just getting the reference? If it is a reference then doing pop_back should make it destroyed, is not it?

ChatGPT says that auto will be not a reference until it is explicitly defined as auto & so probably everything is fine here

@cambragol
Copy link

Maybe it is time for a release from your repository @roginvs ? It's been a while since @alexbatalov popped in here, and people could really do with the advances you've added recently, particularly this one. Certainly people can build their own, but not everyone can.

@roginvs
Copy link
Contributor Author

roginvs commented Jan 10, 2025

We have a common repository https://github.com/fallout2-ce/fallout2-ce , I will try to make a release there.
My repo (https://github.com/roginvs/fallout2-ce) have lots of hacks which are not suitable yet for merging

@roginvs
Copy link
Contributor Author

roginvs commented Jan 10, 2025

@cambragol
Thanks to @APAmk2 we have automatic releases https://github.com/fallout2-ce/fallout2-ce/releases/tag/continious

@cambragol
Copy link

Very Nice!

Not sure what the continuous build is exactly... can we build from https://github.com/fallout2-ce/fallout2-ce? I tried, but it fails (macOS). I am hoping to build a custom version for Sonora which includes the small changes I made for the load/save screen (multiple lines for locations).

Issues and pull requests still made here?

@cambragol
Copy link

No failing on the build. It was an issue with Sequoia. Resolved now.

@roginvs
Copy link
Contributor Author

roginvs commented Jan 12, 2025

@cambragol

Issues and pull requests still made here?

Yes, i think so, at least for now. New PRs I usually replicate into the org repo so no problem to open a discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge of Map Visible at Higher Resolutions
2 participants