-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stencil for hiding initially invisible tiles on high resolution #427
base: main
Are you sure you want to change the base?
Conversation
…t least '/std:c++20'
…t least '/std:c++20'
auto screen_diff = get_screen_diff(); | ||
|
||
while (!tiles_to_visit.empty()) { | ||
auto tileInfo = tiles_to_visit.back(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question to C++ gurus: do we copy element (which is struct) here or just getting the reference? If it is a reference then doing pop_back
should make it destroyed, is not it?
ChatGPT says that auto
will be not a reference until it is explicitly defined as auto &
so probably everything is fine here
Maybe it is time for a release from your repository @roginvs ? It's been a while since @alexbatalov popped in here, and people could really do with the advances you've added recently, particularly this one. Certainly people can build their own, but not everyone can. |
We have a common repository https://github.com/fallout2-ce/fallout2-ce , I will try to make a release there. |
@cambragol |
Very Nice! Not sure what the continuous build is exactly... can we build from https://github.com/fallout2-ce/fallout2-ce? I tried, but it fails (macOS). I am hoping to build a custom version for Sonora which includes the small changes I made for the load/save screen (multiple lines for locations). Issues and pull requests still made here? |
No failing on the build. It was an issue with Sequoia. Resolved now. |
Yes, i think so, at least for now. New PRs I usually replicate into the org repo so no problem to open a discussion here |
This PR adds an overlay to hide parts of the map which should not be visible in the original game resolution. It is achieved by traversing adjacent tiles starting from center tile and marking what parts of the screen are visible.
Before
After
It is using
ddraw.ini
option:Fixes #384