Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling contents added after header creation #283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix handling contents added after header creation #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,8 @@ fn append_path_with_name(
};
let ar_name = name.unwrap_or(path);
if stat.is_file() {
append_fs(dst, ar_name, &stat, &mut fs::File::open(path)?, mode, None)
let file = fs::File::open(path)?;
append_fs(dst, ar_name, &stat, &mut file.take(stat.len()), mode, None)
} else if stat.is_dir() {
append_fs(dst, ar_name, &stat, &mut io::empty(), mode, None)
} else if stat.file_type().is_symlink() {
Expand Down Expand Up @@ -520,7 +521,7 @@ fn append_file(
mode: HeaderMode,
) -> io::Result<()> {
let stat = file.metadata()?;
append_fs(dst, path, &stat, file, mode, None)
append_fs(dst, path, &stat, &mut file.take(stat.len()), mode, None)
}

fn append_dir(
Expand Down