Make sure to restore the error handler

Even when the thrown exception is caught, the error handler should be restored
alexdebril · Jun 4, 2021 · 4f691b6 · 4f691b6
1 parent 1db8a9b
commit 4f691b6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/FeedIo/Reader/Document.php b/src/FeedIo/Reader/Document.php
@@ -68,9 +68,12 @@ function ($errno, $errstr) {
             }
         );
 
-        $domDocument = new \DOMDocument();
-        $domDocument->loadXML($this->content);
-        restore_error_handler();
+        try {
+            $domDocument = new \DOMDocument();
+            $domDocument->loadXML($this->content);
+        } finally {
+            restore_error_handler();
+        }
 
         return $domDocument;
     }