Cast the length to comply with ints provided by JSON Feed #374

alexdebril · Feb 1, 2022 · c7d0852 · c7d0852
1 parent aaa6f99
commit c7d0852
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/FeedIo/Feed/Item/Media.php b/src/FeedIo/Feed/Item/Media.php
@@ -118,20 +118,20 @@ public function setUrl(?string $url) : MediaInterface
     }
 
     /**
-     * @return string
+     * @return integer
      */
     public function getLength() : ? string
     {
         return $this->length;
     }
 
     /**
-     * @param  string $length
+     * @param  mixed $length
      * @return MediaInterface
      */
-    public function setLength(?string $length) : MediaInterface
+    public function setLength($length) : MediaInterface
     {
-        $this->length = $length;
+        $this->length = (string) intval($length);
 
         return $this;
     }

diff --git a/src/FeedIo/Feed/Item/MediaInterface.php b/src/FeedIo/Feed/Item/MediaInterface.php
@@ -72,10 +72,10 @@ public function setUrl(?string $url) : MediaInterface;
     public function getLength() : ? string;
 
     /**
-     * @param  string $length
+     * @param  mixed $length
      * @return MediaInterface
      */
-    public function setLength(?string $length) : MediaInterface;
+    public function setLength($length) : MediaInterface;
 
     /**
      * @return string

diff --git a/tests/samples/feed.json b/tests/samples/feed.json
@@ -20,7 +20,8 @@
       "attachments": [
         {
           "url": "http://localhost/some-resource.jpg",
-          "mime_type": "image/jpg"
+          "mime_type": "image/jpg",
+          "size_in_bytes": 12345
         }
       ]
     },