Update WNP 130 variant params [mozilla#15034]

Use the Nimbus format of ?branch=foo&variant=bar
alexgibson · Sep 2, 2024 · 4536bb3 · 4536bb3
1 parent 15115fe
commit 4536bb3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/bedrock/firefox/tests/test_base.py b/bedrock/firefox/tests/test_base.py
@@ -937,8 +937,8 @@ def test_fx_130_0_0_pl(self, render_mock):
 
     @override_settings(DEV=True)
     def test_fx_130_0_0_en_us_v1(self, render_mock):
-        """Should use default WNP template for en-US locale when v=1"""
-        req = self.rf.get("/firefox/whatsnew/?v=1")
+        """Should use default WNP template for en-US locale when branch=experiment-wnp-130-tabs and variant=v1"""
+        req = self.rf.get("/firefox/whatsnew/?branch=experiment-wnp-130-tabs&variant=v1")
         req.locale = "en-US"
         self.view(req, version="130.0")
         template = render_mock.call_args[0][1]

diff --git a/bedrock/firefox/views.py b/bedrock/firefox/views.py
@@ -581,8 +581,11 @@ def get_template_names(self):
                 template = "firefox/whatsnew/index.html"
         elif version.startswith("130."):
             if locale in ["en-US", "en-GB", "en-CA", "de", "fr", "es-ES", "it", "pl"]:
-                if variant == "1":
-                    template = "firefox/whatsnew/index.html"
+                if nimbus_branch == "experiment-wnp-130-tabs":
+                    if nimbus_variant == "v1":
+                        template = "firefox/whatsnew/index.html"
+                    else:
+                        template = "firefox/whatsnew/whatsnew-fx130.html"
                 else:
                     template = "firefox/whatsnew/whatsnew-fx130.html"
             else: