Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: expand in-progress info for crf-search as seen when debugging is enabled #219

Open
stderr-to-devnull opened this issue Sep 4, 2024 · 1 comment

Comments

@stderr-to-devnull
Copy link

After enabling the debugging, I saw [INFO] level information relayed during in-progress crf-search which I found quite useful and helpful and would like to see it relayed in an optimal way during normal progress.

The debug info in scope:

[2024-09-04T23:12:21Z INFO ab_av1::command::sample_encode] encoding sample 10/16 crf 18

Desired in-progress extra info: encoding sample 10/16 crf 18

  1. It is useful to see how many samples were generated, in my case I use just --sample-every.
  2. It is useful to see the sample progress (10/16) for a given crf value, sort of like a secondary progress indicator.
@alexheretic
Copy link
Owner

Yes I think this would be useful. You can see this info already using ab-av1 sample-encode, crf-search and auto-encode are built on top and didn't have quite as easy access to the info relevant to the sample-encode bit. But it is possible for that to be shared and to add simple info to the other higher level commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants