Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduced dimension in hidden & input layer of FCN by 1. #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tirtho109
Copy link

Bias shouldn't be counted as layer dimension. So the dimension in the input and hidden layer needs to be reduced by 1 for FCNN.js

@alexlenail
Copy link
Owner

Hi @tirtho109
The layer dimension should be dependent on whether the user selects the "show bias units" checkbox. If I'm reading correctly, your PR always decrements the layer width by 1, but we shouldn't assume there's a bias unit unless the user presses the checkbox.

@tirtho109
Copy link
Author

Hi @alexlenail, Thanks for the feedback! Can you check one more time?

@alexlenail
Copy link
Owner

Why do you need a new state variable wasBiasShown when you already have showBias?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants