Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop querying pypi when OUTDATED_IGNORE is on #13

Open
0x26res opened this issue Jan 4, 2023 · 2 comments
Open

Stop querying pypi when OUTDATED_IGNORE is on #13

0x26res opened this issue Jan 4, 2023 · 2 comments

Comments

@0x26res
Copy link

0x26res commented Jan 4, 2023

My understanding of how outdated works is that if the environment variable OUTDATED_IGNORE is set (to any non empty value), then it will stop warning when a package is outdated.

But this will still query pypi in the background. Again, my understanding is that this will happen in a different thread and should not have a detrimental impact on performance.

Nevertheless, some people don't want to have their production environment attempt to query pypi, for various reason (security being the main one).

Would it be possible to change the behaviour of OUTDATED_IGNORE so that it makes outdated do absolutely nothing. or alternatively add another environment variable to disable checks altogether.

Thanks.

@alexmojaki
Copy link
Owner

Good point, I don't know why I didn't do this in the first place. I'd be happy to accept a PR which makes OUTDATED_IGNORE prevent anything from happening at all.

@0x26res
Copy link
Author

0x26res commented Jan 4, 2023

OK, I'll give it a try, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants