Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auction contract example opt_in method doesn't have opt_in allow actions #307

Open
iskysun96 opened this issue Sep 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@iskysun96
Copy link

Subject of the issue

@arc4.abimethod

The opt_in method should have the allow_actions=['OptIn']. Without it, app caller won't be opted in to the contract.

Change code from:

@arc4.abimethod()
def opt_in(self) -> None:
    pass

to

    @arc4.abimethod(allow_actions=["OptIn"])
    def opt_in(self) -> None:
        pass
@iskysun96 iskysun96 added the bug Something isn't working label Sep 9, 2024
@robdmoore
Copy link
Contributor

I suspect there's a number of problems with the auction example, it's been copied down from an original one (in beaker?) that was half baked across a few programming languages haha.

Feel free to submit a pull request to resolve this one.

@robdmoore robdmoore added enhancement New feature or request and removed bug Something isn't working labels Sep 12, 2024
@iskysun96
Copy link
Author

@robdmoore Could you review this PR? I also have a couple questions mentioned in the PR #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants