Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix none src model and skip load ckpt for vllm #50

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix none src model and skip load ckpt for vllm #50

merged 2 commits into from
Sep 3, 2024

Conversation

stcy07
Copy link
Collaborator

@stcy07 stcy07 commented Aug 30, 2024

No description provided.

adoda
adoda approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@adoda adoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@stcy07 stcy07 merged commit 36c6f48 into main Sep 3, 2024
3 checks passed
@stcy07 stcy07 deleted the bugfix/none_src_model_and_skip_load_cpkt branch September 3, 2024 07:12
@SeaOfOcean SeaOfOcean linked an issue Sep 3, 2024 that may be closed by this pull request
[BUG]src param model is none after using set_src_parameter_model #44
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles9304 charles9304 charles9304 approved these changes

@adoda adoda adoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]src param model is none after using set_src_parameter_model
3 participants
@stcy07 @adoda @charles9304