Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spring boot 3.x #3348

Closed
wants to merge 3 commits into from
Closed

Conversation

robberphex
Copy link
Collaborator

@robberphex robberphex commented Feb 27, 2024

Describe what this PR does / why we need it

  • Add module sentinel-spring-webmvc-v6x-adapter, which hold package com.alibaba.csp.sentinel.adapter.spring.webmvc_v6x, for modularity.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 55.49133% with 77 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (1.8@41569f9). Click here to learn what that means.

Files Patch % Lines
...spring/webmvc_v6x/AbstractSentinelInterceptor.java 66.10% 12 Missing and 8 partials ⚠️
...pring/webmvc_v6x/config/WebServletLocalConfig.java 0.00% 18 Missing ⚠️
...ing/webmvc_v6x/config/SentinelPreWebMvcConfig.java 0.00% 13 Missing ⚠️
...pter/spring/webmvc_v6x/SentinelWebInterceptor.java 45.00% 6 Missing and 5 partials ⚠️
...spring/webmvc_v6x/config/SentinelWebMvcConfig.java 62.96% 8 Missing and 2 partials ⚠️
...spring/webmvc_v6x/SentinelWebTotalInterceptor.java 50.00% 3 Missing and 1 partial ⚠️
...g/webmvc_v6x/config/SentinelWebMvcTotalConfig.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             1.8    #3348   +/-   ##
======================================
  Coverage       ?   45.90%           
  Complexity     ?     2141           
======================================
  Files          ?      429           
  Lines          ?    12895           
  Branches       ?     1729           
======================================
  Hits           ?     5919           
  Misses         ?     6279           
  Partials       ?      697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panxiaojun233
panxiaojun233 previously approved these changes Feb 28, 2024
Copy link
Collaborator

@panxiaojun233 panxiaojun233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants